fix(manifests): Updating manifests since now storage class is defined…#2
Open
Jcardoso-Instadeep wants to merge 4 commits into
Open
fix(manifests): Updating manifests since now storage class is defined…#2Jcardoso-Instadeep wants to merge 4 commits into
Jcardoso-Instadeep wants to merge 4 commits into
Conversation
… at the experiment level, instead of during cluster import
|
|
… at the experiment level, instead of during cluster import
Contributor
|
Could you add them but commented, the goal of these manifest is to start experiments with a minimal configuration |
Author
|
Fixed it 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR comes after the changes done in AIChor where the storage class is no longer defined during import but rather at experiment level, in the manifest
See: MR